Fix transaction card payment source label - #97
Merged
Conversation
Cards referenced transactions.businessRevenue, which does not exist in locale files. Align display with TransactionForm using businessCash and a shared payment-source translation helper. Co-authored-by: Cursor <cursoragent@cursor.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull request overview
Fixes transaction cards (expenses/fees) rendering a raw i18n key for the payment source by aligning the card display with the same translation keys used in TransactionForm.
Changes:
- Added
getPaymentSourceTranslationKey()helper insrc/lib/transactionUtils.tsto mapPaymentSourcevalues to existingtransactions.*locale keys. - Updated
TransactionsPageto use the shared helper for rendering the payment source label and corrected mixed-source breakdown copy to usebusinessCash(instead of the non-existentbusinessRevenuekey).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/lib/transactionUtils.ts | Introduces a typed mapping helper from PaymentSource to valid transaction locale keys. |
| src/components/pages/transactions/TransactionsPage.tsx | Uses the shared helper to translate the payment source on transaction cards and fixes mixed breakdown wording. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Source: transactions.businessRevenue(raw i18n key) instead of a translated label.getPaymentSourceTranslationKey()intransactionUtils.tsso card display uses the same locale keys asTransactionForm(businessCash,externalFunds,mixedSources).businessCashinstead of the non-existentbusinessRevenuekey.Test plan
Source: Business Cash(not a raw key).Made with Cursor