Repository navigation
fix(docs): separate interviewer Q from Mid/Principal answers, not a dialogue - #23
Merged
Merged
Conversation
…ialogue Across 32 docs, "## Interviewer probes" was shaped as a two-turn dialogue: Mid: "<question>" followed by Principal: <answer>, which reads as Mid asking a question and Principal answering it. The intended shape (per CONTEXT.md) is one shared interviewer question with two independent answers at different depth. Fixed by promoting the embedded question to its own bold line, then writing a new short Mid-level answer (correct but surface-level, missing the nuance/incident/tradeoff the Principal answer covers) and leaving every Principal answer byte-for-byte unchanged. 5 files in the original candidate list (37, 39, 56, 58, 59) were checked and found already correctly shaped -- their Mid: lines use quoted short-answer phrases, not restated questions, which an initial grep pattern couldn't distinguish -- so they were left untouched. Also fixes a quality regression the batch-fix agents introduced: 92 instances of "Yes — ...", "No — ...", "Not really — ..." constructions in the new Mid answers, violating this repo's no-em-dash style rule (missed in the original fix prompt). Rewritten using periods, colons, or parens per the existing convention. 3 pre-existing em-dashes outside the Interviewer probes section (Sources entries, invariant tables) were left alone as out of scope for this fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
## Interviewer probeswas shaped as a two-turn dialogue:Mid: "<question>"followed byPrincipal: <answer>, which reads as Mid asking a question and Principal answering it. The intended shape (perCONTEXT.md) is one shared interviewer question with two independent answers at different depth.37-data-and-model-poisoning.md,39-excessive-agency.md,56-a2a-protocol.md,58-rag-architecture-attacks.md,59-vector-stores.md) were checked and found already correctly shaped -- theirMid:lines use quoted short-answer phrases, not restated questions, which the initial detection grep couldn't distinguish -- so they were left untouched."Yes — ...", "No — ...", "Not really — ..."constructions in the new Mid answers, violating this repo's no-em-dash style rule (a rule I missed restating in the original fix prompt). Rewritten using periods, colons, or parens per the existing convention. 3 pre-existing em-dashes outside the Interviewer probes section (Sources entries, invariant tables) were left alone as out of scope for this fix.Test plan
pytest tests/-- 11/11 passed.mkdocs build --strict-- clean, no errors.Principal:answer verified unchanged (only theMid:line and question formatting were touched per file).https://claude.ai/code/session_011f1KhQCYiUUPFKco7pguLC