Secure Network backend transport with PSK - #32
Closed
rchatham wants to merge 2 commits into
Closed
Conversation
…loopback' into HEAD # Conflicts: # Sources/PeerConnectionManager.swift # Sources/PeerConnectionTransports.swift
Owner
Author
|
Superseded by consolidated PR #42. No commits were discarded; this branch is preserved as a recovery and reference point. Addressed review findings were replied to and resolved before consolidation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an authenticated encrypted option for the experimental Network framework backend using TLS pre-shared keys, and updates loopback coverage to exercise the secured path.
Changes
PeerConnectionNetworkSecurity:.unauthenticatedpreserves source-compatible plaintext diagnostics/migration behavior..preSharedKey(Data)configures TLS-PSK for Network framework connections.networkSecurity:toPeerConnectionManagerwith default.unauthenticated.NWParameterswith TLS options andsec_protocol_options_add_pre_shared_keywhen.preSharedKeyis selected.Verification
swift test --filter NetworkPeerCoordinatorTests— passedswift test --filter NetworkPeerLoopbackTests— passedswift test— 98 tests passedxcodebuild test -project PeerConnectivity.xcodeproj -scheme PeerConnectivity -destination 'platform=iOS Simulator,name=iPhone 16,OS=18.3.1' -configuration Debug— 98 tests passedpull_requestCI — Swift Package Tests and Xcode Project Tests passedpushCI — Swift Package Tests and Xcode Project Tests passed after rerunning an initial Xcode job failureNotes / limitations
.networkFrameworkremains opt-in and still lacks streams/resource/UI parity..unauthenticatedremains available for source compatibility and diagnostics, but docs explicitly mark it as plaintext and not for sensitive data.Stack context
Stacked on PR #31 (
feature/network-migration-local-loopback). This is the secure transport hardening slice of the Network migration stack.