Isolate Network loopback CI - #41
Closed
rchatham wants to merge 2 commits into
Closed
Conversation
…tion-cleanup' into HEAD
Owner
Author
|
Superseded by consolidated PR #42. No commits were discarded; this branch is preserved as a recovery and reference point. Addressed review findings were replied to and resolved before consolidation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Isolates real Network.framework/Bonjour loopback tests into focused retryable CI steps while keeping unit test failures easier to diagnose.
Changes
NetworkPeerLoopbackTestsfrom the main CI passes:CI=trueandPEERCONNECTIVITY_RUN_NETWORK_E2Eis not set.-skip-testing:PeerConnectivityTests/NetworkPeerLoopbackTestsin the main simulator test step.swift test --filter NetworkPeerLoopbackTestsxcodebuild test ... -only-testing:PeerConnectivityTests/NetworkPeerLoopbackTestsNetworkBackendGuide.md.Verification
CI=true swift test --filter NetworkPeerLoopbackTests— 6 tests skipped as expectedPEERCONNECTIVITY_RUN_NETWORK_E2E=1 CI=true swift test --filter NetworkPeerLoopbackTests— 6 tests passedswift test— 109 tests passedxcodebuild test -project PeerConnectivity.xcodeproj -scheme PeerConnectivity -destination 'platform=iOS Simulator,name=iPhone 16,OS=18.3.1' -configuration Debug— 109 tests passedCI=true xcodebuild test ... -skip-testing:PeerConnectivityTests/NetworkPeerLoopbackTests— 103 tests passedPEERCONNECTIVITY_RUN_NETWORK_E2E=1 CI=true xcodebuild test ... -only-testing:PeerConnectivityTests/NetworkPeerLoopbackTests— 6 tests passedpull_requestCI — Swift Package Tests and Xcode Project Tests passedpushCI — Swift Package Tests and Xcode Project Tests passedNotes / limitations
swift test/xcodebuild testcontinue running the Network loopback tests unless the caller explicitly uses CI-style skip/filter arguments.Stack context
Stacked on PR #40 (
feature/network-migration-connection-cleanup). This is the CI E2E flake-isolation slice of the Network migration stack.