VPAAMP-733 GetStreamFormat() wrong for HLS-TS when useMp4Demux=true#1705
Merged
Conversation
Reason for Change: GetStreamFormat() returns wrong A/V format for HLS-TS
when useMp4Demux=true
Summary of Changes:
- Move return UNKNOWN format to PrivAamp from StreamAbstraction
- Extend GetStreamFormat L1 tests to verify the change
Test Procedure: Run L1 tests
Priority: P1
Risks: Low
cpc005
reviewed
Jul 9, 2026
anshephe
approved these changes
Jul 9, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes incorrect stream format reporting for HLS-TS when UseMp4Demux is enabled by limiting the “unknown until init fragment parsed” behavior to fMP4 HLS. This aligns StreamAbstractionAAMP_HLS::GetStreamFormat() with how Mp4Demux is intended to behave in the HLS pipeline.
Changes:
- Update HLS
GetStreamFormat()to set A/V formats toFORMAT_UNKNOWNonly whenUseMp4Demuxis enabled and the media format iseMEDIAFORMAT_HLS_MP4. - Add L1 tests covering both fMP4 HLS and TS HLS cases when
UseMp4Demuxis enabled.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
fragmentcollector_hls.cpp |
Restricts the FORMAT_UNKNOWN override to HLS fMP4 only, preserving correct TS formats. |
test/utests/tests/StreamAbstractionAAMP_HLS/FunctionalTests.cpp |
Adds unit tests validating the updated GetStreamFormat() behavior for fMP4 vs TS under UseMp4Demux. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for Change: GetStreamFormat() returns wrong A/V format for HLS-TS
when useMp4Demux=true
Summary of Changes:
Test Procedure: Run L1 tests
Priority: P1
Risks: Low