Skip to content

RDKEMW-20349 : Change discovery.watchedV2 return type to void#80

Merged
swethasukumarr merged 4 commits into
developfrom
feature/fix0.6.2
Jul 10, 2026
Merged

RDKEMW-20349 : Change discovery.watchedV2 return type to void#80
swethasukumarr merged 4 commits into
developfrom
feature/fix0.6.2

Conversation

@swethasukumarr

Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI review requested due to automatic review settings June 15, 2026 19:39

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Discovery watchedV2 API to be fire-and-forget (no return payload), aligning the C++ interface/implementation, tests, demo output, and OpenRPC fixtures with a void/null result.

Changes:

  • Change Discovery.watchedV2 return type from Result<bool> to Result<void> and switch implementation from helper_.get(...) to helper_.invoke(...).
  • Update unit/component tests and the API demo app to stop expecting a boolean result.
  • Update OpenRPC fixtures to define a null result schema and null example values for watchedV2.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
include/firebolt/discovery.h Updates the public interface return type and return docs for watchedV2.
src/discovery_impl.h Updates DiscoveryImpl method signature to Result<void>.
src/discovery_impl.cpp Implements watchedV2 as an invoke returning Result<void>.
test/unit/discoveryTest.cpp Adjusts mocks and assertions for Result<void> and invoke(...).
test/component/discoveryTest.cpp Removes boolean result expectation for watchedV2.
test/api_test_app/apis/discoveryDemo.cpp Updates demo output to reflect no boolean return value.
docs/openrpc/the-spec/firebolt-open-rpc.json Changes watchedV2 result schema/examples to null.
docs/openrpc/openrpc/discovery.json Changes watchedV2 result schema/examples to null.

Comment thread include/firebolt/discovery.h
Comment thread docs/openrpc/openrpc/discovery.json
Comment thread docs/openrpc/the-spec/firebolt-open-rpc.json
@swethasukumarr swethasukumarr changed the title RDKEMW-17483 Change discovery.watchedV2 return type to void RDKEMW-20349 : Change discovery.watchedV2 return type to void Jun 22, 2026
brendanobra
brendanobra previously approved these changes Jun 29, 2026
Copilot AI review requested due to automatic review settings June 29, 2026 15:47

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated no new comments.

Copilot AI review requested due to automatic review settings July 6, 2026 14:25

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated no new comments.

Comment thread src/discovery_impl.cpp Outdated
satlead
satlead previously approved these changes Jul 9, 2026
Copilot AI review requested due to automatic review settings July 9, 2026 16:47

This comment was marked as spam.

Copilot AI review requested due to automatic review settings July 9, 2026 16:49

This comment was marked as spam.

@swethasukumarr swethasukumarr merged commit 0c3f309 into develop Jul 10, 2026
17 checks passed
@swethasukumarr swethasukumarr deleted the feature/fix0.6.2 branch July 10, 2026 15:24
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 10, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants