Support/0.6.x#88
Closed
swethasukumarr wants to merge 3 commits into
Closed
Conversation
Patch Release 0.6.1
Release 0.6.2
…#87) * RDKEMW-17673 : Add info coverage gate to CI * RDKEMW-17673 : Address copilot comments * Fix api test app in CI * Fix copilot comment * RDKEMW-17667 : Add timezone getter method and onTimeZoneChanged event * RDKEMW-17667: Fix clang-format issue and onTimeZoneChanged to app OpenRPC spec * RDKEMW-17667: Fix comments * RDKEMW-17667 : Add timeZone method to api test app * RDKEMW-14887 : Update Stats.memoryUsage api to return value in bytes (#82) * RDKEMW-14887 : Update Stats.memoryUsage api to return value in bytes * RDKEMW-14887 : Fix spacing issues * address copilot comment * clang format fix --------- Co-authored-by: rajanika <rajanikatsr@gmail.com> Co-authored-by: rradha446 <rajanika_radhakrishnan@comcast.com> * RDKEMW-20911 : Return full JSON document from Actions.intent/onIntent * RDKEMW-20911 : Address copilot comments --------- Co-authored-by: rajanika <rajanikatsr@gmail.com> Co-authored-by: rradha446 <rajanika_radhakrishnan@comcast.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the client and OpenRPC fixtures to align with newer API shapes/units (Stats memory usage now in bytes with 64-bit fields; Actions intent now modeled as a structured JSON document; Localization gains a timeZone getter/event), and adds CI coverage artifacts plus an informational “coverage gate” with baseline tracking.
Changes:
- Update
Stats.memoryUsageschema/JSON parsing/tests from*KiBuint32_tfields to byte-baseduint64_tfields. - Add
Localization.timeZonegetter +Localization.onTimeZoneChangedevent across implementation, tests, and OpenRPC fixtures. - Update Actions intent handling to support non-string wire payloads and add CI coverage reporting (lcov artifacts + baseline comparison scripts).
Reviewed changes
Copilot reviewed 25 out of 25 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| test/unit/statsTest.cpp | Updates unit test expectations to new Stats memoryUsage field names/types. |
| test/unit/localizationTest.cpp | Adds unit tests for Localization.timeZone and its event subscription. |
| test/unit/actionsTest.cpp | Updates Actions intent unit test to the new payload shape. |
| test/component/statsTest.cpp | Updates component test expectations to new Stats memoryUsage field names/types. |
| test/component/localizationTest.cpp | Adds component tests for timeZone getter and onTimeZoneChanged event behavior. |
| test/component/actionsGeneratedTest.cpp | Updates Actions intent component tests and event trigger payload. |
| test/api_test_app/utils.h | Adds failure counting to auto-run demo flow. |
| test/api_test_app/main.cpp | Auto-run now aggregates failures and returns non-zero when methods fail. |
| test/api_test_app/apis/statsDemo.cpp | Updates output labeling for byte-based memory values. |
| test/api_test_app/apis/localizationDemo.cpp | Adds demo method for Localization.timeZone. |
| src/localization_impl.h | Adds timeZone and subscribeOnTimeZoneChanged to LocalizationImpl interface. |
| src/localization_impl.cpp | Implements timeZone getter and onTimeZoneChanged subscription. |
| src/json_types/stats.h | Updates Stats JSON parsing to new field names and uint64 types. |
| src/json_types/actions.h | Adds JsonString helper for serializing non-string JSON payloads to string. |
| src/actions_impl.cpp | Switches Actions intent/onIntent parsing to JsonString. |
| include/firebolt/stats.h | Updates public Stats MemoryInfo fields to uint64 and documents bytes. |
| include/firebolt/localization.h | Adds public Localization.timeZone + subscribeOnTimeZoneChanged API. |
| docs/openrpc/the-spec/firebolt-open-rpc.json | Updates Actions intent schema, adds Localization timeZone + event, updates Stats schema/summary. |
| docs/openrpc/the-spec/firebolt-open-rpc--legacy.json | Updates Stats schema/summary to bytes and new field names. |
| docs/openrpc/the-spec/firebolt-app-open-rpc.json | Adds Localization.onTimeZoneChanged notifier and updates Stats schema. |
| docs/openrpc/openrpc/stats.json | Updates Stats OpenRPC module doc to bytes and new field names. |
| docs/openrpc/openrpc/localization.json | Adds Localization.timeZone OpenRPC module doc. |
| .github/workflows/ci.yml | Emits lcov, uploads coverage artifacts, adds coverage gate + baseline update job. |
| .github/scripts/compare_coverage.py | New informational coverage comparison + baseline extraction script. |
| .github/scripts/compare_coverage_test.py | New unit/integration tests for compare_coverage.py. |
Comment on lines
+41
to
+49
| class JsonString : public Firebolt::JSON::NL_Json_Basic<std::string> | ||
| { | ||
| public: | ||
| void fromJson(const nlohmann::json& json) override { value_ = json.dump(); } | ||
| std::string value() const override { return value_; } | ||
|
|
||
| private: | ||
| std::string value_; | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.