Skip to content

Feature/rdkemw 20911 develop#89

Merged
swethasukumarr merged 3 commits into
developfrom
feature/RDKEMW-20911-develop
Jul 8, 2026
Merged

Feature/rdkemw 20911 develop#89
swethasukumarr merged 3 commits into
developfrom
feature/RDKEMW-20911-develop

Conversation

@swethasukumarr

Copy link
Copy Markdown
Contributor

No description provided.

@swethasukumarr swethasukumarr changed the base branch from develop to support/0.6.x July 8, 2026 19:52
@swethasukumarr swethasukumarr changed the base branch from support/0.6.x to develop July 8, 2026 19:52

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Actions module to handle Actions.intent / Actions.onIntent responses where the Firebolt backend sends a JSON object payload (e.g. {"intent":"launch","intentId":1}), while preserving the existing C++ API surface that exposes the value as a std::string.

Changes:

  • Added a JSON type adapter to serialize arbitrary JSON payloads into a compact JSON string for the Actions APIs.
  • Switched ActionsImpl::intent() and subscribeOnIntent() to use the new adapter and updated unit/component tests accordingly.
  • Updated the OpenRPC fixture and changelog to reflect the intent payload shape.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
test/unit/actionsTest.cpp Updates unit test to mock an object payload and validate by parsing returned JSON string.
test/component/actionsGeneratedTest.cpp Updates component test expectations and event trigger payload to the object form.
src/json_types/actions.h Adds JsonString adapter to convert JSON responses into std::string via serialization.
src/actions_impl.cpp Uses JsonString for Actions.intent getter and Actions.onIntent subscription parsing.
docs/openrpc/the-spec/firebolt-open-rpc.json Updates Actions.intent / Actions.onIntent result schema and examples to object payload.
CHANGELOG.md Adds 0.6.3 entry describing the fix.

Comment thread src/json_types/actions.h
Comment thread CHANGELOG.md
@swethasukumarr swethasukumarr merged commit b4b261e into develop Jul 8, 2026
15 of 16 checks passed
@swethasukumarr swethasukumarr deleted the feature/RDKEMW-20911-develop branch July 8, 2026 20:06
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 8, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants