Feature/rdkemw 20911 develop#89
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Actions module to handle Actions.intent / Actions.onIntent responses where the Firebolt backend sends a JSON object payload (e.g. {"intent":"launch","intentId":1}), while preserving the existing C++ API surface that exposes the value as a std::string.
Changes:
- Added a JSON type adapter to serialize arbitrary JSON payloads into a compact JSON string for the Actions APIs.
- Switched
ActionsImpl::intent()andsubscribeOnIntent()to use the new adapter and updated unit/component tests accordingly. - Updated the OpenRPC fixture and changelog to reflect the intent payload shape.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| test/unit/actionsTest.cpp | Updates unit test to mock an object payload and validate by parsing returned JSON string. |
| test/component/actionsGeneratedTest.cpp | Updates component test expectations and event trigger payload to the object form. |
| src/json_types/actions.h | Adds JsonString adapter to convert JSON responses into std::string via serialization. |
| src/actions_impl.cpp | Uses JsonString for Actions.intent getter and Actions.onIntent subscription parsing. |
| docs/openrpc/the-spec/firebolt-open-rpc.json | Updates Actions.intent / Actions.onIntent result schema and examples to object payload. |
| CHANGELOG.md | Adds 0.6.3 entry describing the fix. |
brendanobra
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.