RDKB-65466 : secvuln for EVP_verifyfinal#18
Open
ashutoshharry wants to merge 2 commits into
Open
Conversation
secvuln for EVP_verifyfinal
There was a problem hiding this comment.
Pull request overview
This PR updates the OpenSSL signature verification path to correctly interpret EVP_VerifyFinal() return values, addressing a security issue where verification failures could be treated as successful verification.
Changes:
- Update
EVP_VerifyFinal()result handling to only mark verification as successful whenerr == 1. - Adjust success/failure logging around the verification result.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
secvuln for EVP_verifyfinal