Skip to content

RDKB-65950 Fix HTTP login session cookie Secure flag handling #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pavankumar464 wants to merge 2 commits into
base: develop
Choose a base branch
from
+17 −8
Open

RDKB-65950 Fix HTTP login session cookie Secure flag handling #28

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5dc2e19
RDKB-65950 Fix HTTP login session cookie Secure flag handling
pavankumar464 Jul 10, 2026
60a316d
RDKB-65950 Align HTTPS cookie conditional indentation
pavankumar464 Jul 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 17 additions & 8 deletions jsts/jst_prefix.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,17 @@ var $_SERVER = new Proxy({}, {
var $_SESSION = {};
var $_jst_session = null;
var $_val_input = {};

function is_https_request()
{
var https = getenv('HTTPS');
if(https === false || https === undefined || https === null)
return false;

var value = String(https).toLowerCase();
return (value === 'on' || value === '1' || value === 'true');
}

function session_start()
{
if($_jst_session)
Expand All @@ -99,11 +110,10 @@ function session_start()
return;
}
ccsp_session.start();
var host = getenv('HTTPS');
if (host == false)
var $cookie = "Set-Cookie: DUKSID=" + ccsp_session.getId() + "; httponly";
if (is_https_request())
var $cookie = "Set-Cookie: DUKSID=" + ccsp_session.getId() + "; secure" + "; httponly";
else
var $cookie = "Set-Cookie: DUKSID=" + ccsp_session.getId() + "; secure" + "; httponly";
var $cookie = "Set-Cookie: DUKSID=" + ccsp_session.getId() + "; httponly";
Comment on lines +113 to +116
header($cookie);
$_jst_session = ccsp_session.getData();
$_SESSION = new Proxy($_jst_session, {
Expand All @@ -127,11 +137,10 @@ function session_start()
}
function session_create(){
ccsp_session.create();
var host = getenv('HTTPS');
if (host == false)
var $cookie = "Set-Cookie: DUKSID=" + ccsp_session.getId() + "; httponly";
else
if (is_https_request())
var $cookie = "Set-Cookie: DUKSID=" + ccsp_session.getId() + "; secure" + "; httponly";
else
var $cookie = "Set-Cookie: DUKSID=" + ccsp_session.getId() + "; httponly";
Comment on lines +140 to +143
header($cookie);
$_jst_session = ccsp_session.getData();
$_SESSION = new Proxy($_jst_session, {
Expand Down
Loading