RDKBACCL-1853 SSH and WebUI not working - Ethernet Configurable WAN I…#363
Open
anatar818 wants to merge 1 commit into
Open
RDKBACCL-1853 SSH and WebUI not working - Ethernet Configurable WAN I…#363anatar818 wants to merge 1 commit into
anatar818 wants to merge 1 commit into
Conversation
…nterface Integration Reason for change: Verify configurable wan interface in BPI R4 (ethagent functionality) Test Procedure: Build and flash the image ,Validate wan functionality for the customized interface name Risks: None
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to restore SSH/WebUI accessibility when the WAN interface name is configurable (e.g., on BPI R4), by ensuring firewall logic uses the correct WAN interface name when generating iptables rules.
Changes:
- When
FEATURE_RDKB_CONFIGURABLE_WAN_INTERFACEis enabled, initializecurrent_wan_ifnamefromsyscfg(wan_physical_ifname) if sysevent doesn’t provide it. - When ETH WAN is enabled, generate the SSH filter iptables rule using
current_wan_ifname(when set) under the configurable-WAN feature flag.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+2386
to
+2393
| if ('\0' == current_wan_ifname[0]) { | ||
| char wanInterface[BUFLEN_64] = {'\0'}; | ||
| syscfg_get(NULL, "wan_physical_ifname", wanInterface, sizeof(wanInterface)); | ||
| if(wanInterface[0] != '\0') | ||
| snprintf(current_wan_ifname, sizeof(current_wan_ifname), "%s", wanInterface); | ||
| else | ||
| snprintf(current_wan_ifname, sizeof(current_wan_ifname), "%s", default_wan_ifname); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…nterface Integration
Reason for change: Verify configurable wan interface in BPI R4 (ethagent functionality)
Test Procedure: Build and flash the image ,Validate wan functionality for the customized interface name
Risks: None