XER10-3108 , SHARMAN-4211, SHARMAN-4218, XER10-3122 : Restart SSH after lease change.#217
Merged
Merged
Conversation
Restart WAN management services on IPv4 and IPv6 setup to ensure proper binding of management services to the new WAN addresses.
Contributor
There was a problem hiding this comment.
Pull request overview
Restarting WAN management services during IPv4/IPv6 setup so services like sshd can re-bind to updated WAN addresses after bring-up or lease/address changes.
Changes:
- Move
wanmgr_services_restart()out of the “first-time started” block for IPv4 so it runs on lease/address changes as well. - Move
wanmgr_services_restart()out of the “first-time started” block for IPv6 so it runs on lease/address changes as well.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…date related logic
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
Comments suppressed due to low confidence (1)
source/WanManager/wanmgr_dhcpv6_apis.c:1793
strncpyis using the full destination buffer size, which can leaveIpv6DataNew.addressunterminated when the source is exactlyBUFLEN_48bytes. This can lead to over-reads when the address is later logged/used in command strings.
CcspTraceWarning(("%s %d IANA is not assigned in this IPC msg, but we have IANA configured from previous lease. Assuming only IAPD renewed. \n", __FUNCTION__, __LINE__));
strncpy(Ipv6DataNew.address, pDhcp6cInfoCur->address, sizeof(Ipv6DataNew.address));
Ipv6DataNew.addrAssigned = true;
S-Parthiban-Selvaraj
changed the title
…ix matches current lease
guto86
approved these changes
Jul 13, 2026
LakshminarayananShenbagaraj
approved these changes
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restart WAN management services on IPv4 and IPv6 setup to ensure proper binding of management services to the new WAN addresses.