Repository navigation
Conversation
* Update `ApiConfig` to include `allowInsecureTls` property for local testing * Refactor `NetworkModule` to use the `allowInsecureTls` flag when configuring `OkHttpClient` instead of checking the URL protocol prefix
* Update `ApiConfig` to include `allowInsecureTls` property for local testing * Refactor `NetworkModule` to use the `allowInsecureTls` flag when configuring `OkHttpClient` instead of checking the URL protocol prefix
* Update `ApiConfig` test helper to include the `allowInsecureTls` parameter * Refactor `OkHttpClient` provider tests to explicitly verify standard vs. unsafe clients based on the `allowInsecureTls` flag * Add assertions to validate hostname verification behavior for secure and insecure configurations
dubdabasoduba
left a comment
dubdabasoduba
left a comment
Collaborator
There was a problem hiding this comment.
Clean up the linting issues then we can merge it
| if (config.baseUrl.startsWith("https")) { | ||
| OkHttpClient.Builder() | ||
| } else { | ||
| if (config.allowInsecureTls) { |
Collaborator
There was a problem hiding this comment.
Smart way to do it thanks
dubdabasoduba
enabled auto-merge
August 20, 2026 08:33
There was a problem hiding this comment.
Pull request overview
This PR introduces an explicit ApiConfig.allowInsecureTls switch and updates the app DI NetworkModule to use the unsafe OkHttp builder only when that flag is enabled, fixing the prior scheme-based logic that failed for self-signed https:// endpoints during local testing.
Changes:
- Add
allowInsecureTls(defaultfalse) toApiConfigto explicitly opt into bypassing TLS verification. - Update
NetworkModule.provideOkHttpClientto chooseUnsafeOkHttpClientbased onallowInsecureTlsrather than URL scheme. - Update
NetworkModuleTestto validate the new behavior and expectations.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| android/momo-api-sdk/src/commonMain/kotlin/io/rekast/sdk/utils/ApiConfig.kt | Adds allowInsecureTls flag to runtime SDK configuration. |
| android/app/src/main/kotlin/io/rekast/sdk/app/di/NetworkModule.kt | Switches unsafe-client selection logic to be driven by the new config flag. |
| android/app/src/test/kotlin/io/rekast/sdk/app/di/NetworkModuleTest.kt | Updates tests and assertions to reflect allowInsecureTls behavior. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
60
to
+64
| ApiConfig( | ||
| baseUrl = "http://10.0.2.2:8080/", | ||
| apiUserId = "user-id", | ||
| environment = "sandbox" | ||
| environment = "sandbox", | ||
| allowInsecureTls = true |
Comment on lines
+122
to
+127
| val isUnsafe = try { | ||
| client.hostnameVerifier.verify("any-hostname.example.com", null) | ||
| } catch (e: NullPointerException) { | ||
| false | ||
| } | ||
| org.junit.Assert.assertFalse(isUnsafe) |
Comment on lines
+159
to
163
| if (config.allowInsecureTls) { | ||
| UnsafeOkHttpClient().unsafeOkHttpClient | ||
| } else { | ||
| OkHttpClient.Builder() | ||
| } |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
* Update indentation and line wrapping for the `try-catch` block in `NetworkModuleTest` to comply with formatting standards.
auto-merge was automatically disabled
August 25, 2026 08:54
Head branch was pushed to by a user without write access
Author
Linting issues resolved! |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds an option to allow insecure TLS in ApiConfig
In NetworkModule.kt, there is a flawed condition for when to use the UnsafeOkHttpClient. This logic assumes any URL starting with https has a valid production certificate, and any URL that doesn't (i.e., http://) needs TLS disabled. But http:// traffic doesn't use TLS anyway! The actual use case for UnsafeOkHttpClient is for local testing with self-signed HTTPS certificates. If a developer uses a self-signed https://10.0.2.2/, this code will give them a regular OkHttpClient which will immediately crash on a certificate error.
Type of change
Checklist
./gradlew build).