Conversation
And remove RS__ from properties
Member
|
What would be the strategy for a RS to figure out which line height compensation to use? Here's an attempt:
|
Collaborator
Author
|
Yeah that makes sense as I treated it like this lately as it was the most obvious way to do it. We'd better document it for clarity. I am also thinking about the case where Latin may not be the default script of the app, in which case we should warn to not blindly apply this logic. |
Abstract the rule for app/publication instead of treating non-latin-based apps as outliers.
JayPanoz
commented
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This creates a JSON file for language-specific values in ReadiumCSS-base module so that they can be accessible to external consumers of ReadiumCSS.
A use case would be to adjust the value you submit for line height to the Preferences API in Navigators depending on the language, or adjust font-family putting the value in the selection as sort of a default value.