Fix hash verification for CGW pipelines (tkn) - #168
Merged
Conversation
The isHashMissing check was only evaluated when no hash file existed in the directory. CGW pipelines has a sha256sum.txt but it hashes individual binaries (linux/amd64/tkn) rather than tarballs (tkn-linux-amd64.tar.gz), causing verification to fail. Move the isHashMissing check to the top of getOnlineHash() so it short-circuits before looking for hash files in the directory. Reported upstream to the pipelines team. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
isHashMissingoverride was only checked when no hash file existed in the directory listingsha256sum.txt, but it hashes individual binaries (linux/amd64/tkn) rather than tarballs (tkn-linux-amd64.tar.gz), so the lookup fails withDid not find file "tkn-linux-amd64.tar.gz" in the given hash fileisHashMissingcheck to the top ofgetOnlineHash()so it short-circuits before fetching or parsing the hash fileReported upstream to the pipelines team — this can be reverted once they fix their
sha256sum.txtgeneration.Test plan
Known versionmirror job passes withtkn: "1.15"CGW mirror clientsjob passes withtkn: "latest"🤖 Generated with Claude Code