Skip to content

Drop gdx/gdxrrw dependencies from scripts - #2485

Merged
tonnrueter merged 9 commits into
remindmodel:developfrom
tonnrueter:dev/rm-gdxrrw
Sep 28, 2026
Merged

tonnrueter merged 9 commits into
remindmodel:developfrom
tonnrueter:dev/rm-gdxrrw

Conversation

@tonnrueter

@tonnrueter tonnrueter commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

Purpose of this PR

Removes the gdxrrw / gdx R-package dependency from REMIND's own R scripts. No functional change to the model.

  • Dropped gdxrrw/gdx references in scripts/start/prepare.R, scripts/start/prepareAndRun.R, scripts/input/climateAssessmentInterimRun.R, scripts/output/comparison/checkClimatePercentiles.R.
  • Ported GDX writing to quitte::write.gdx/gamstransfer-based method in scripts/input/climateAssessmentImpulseResponse.R,
    scripts/input/run_KotzWenz_damages.R. Change is behaviour-preserving as explicit zeros are kept on disk, and the GAMS execute_loadpoint consumers load identical values (verified via MVE).

Type of change

Indicate the items relevant for your PR by replacing ◻️ with ☑️.
Do not delete any lines. This makes it easier to understand which areas are affected by your changes and which are not.

Parts concerned

  • ◻️ GAMS Code
  • ☑️ R-scripts
  • ◻️ Documentation (GAMS incode documentation, comments, tutorials)
  • ◻️ Input data / CES parameters
  • ◻️ Tests, CI/CD (continuous integration/deployment)
  • ◻️ Configuration (switches in main.gms, default.cfg, and scenario_config*.csv files)
  • ◻️ Other (please give a description)

Impact

  • ◻️ Bug fix
  • ☑️ Refactoring
  • ◻️ New feature
  • ◻️ Change of parameter values or input data (including CES parameters)
  • ◻️ Minor change (default scenarios show only small differences)
  • ◻️ Fundamental change of results of default scenarios

Checklist

Do not delete any line. Leave unfinished elements unchecked so others know how far along you are.
In the end all checkboxes must be ticked before you can merge
.

  • I executed the automated model tests (make test) after my final commit and all tests pass (FAIL 0)
  • I adjusted the reporting in remind2 if and where it was needed
  • I adjusted the madrat packages (mrremind and other packages involved) for input data generation if and where it was needed
  • My code follows the coding etiquette
  • I explained my changes within the PR, particularly in hard-to-understand areas
  • I checked that the in-code documentation is up-to-date
  • I adjusted forbiddenColumnNames in readCheckScenarioConfig.R in case the PR leads to deprecated switches
  • I updated the CHANGELOG.md correctly (added, changed, fixed, removed, input data/calibration)

Further information (optional)

  • Runs with these changes are here:
  • Comparison of results (what changes by this PR?):

@tonnrueter tonnrueter self-assigned this Sep 28, 2026
@tonnrueter
tonnrueter merged commit 6e873c1 into remindmodel:develop Sep 28, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants