Conversation
added 4 commits
September 23, 2026 14:33
…ssions shares and remove cm_NDC_version switch as old NDC versions are not supported anymore
fbenke-pik
reviewed
Sep 30, 2026
| *** Quick patch: cm_NDC_version switch was removed (PBL 2026 NDC inputs carry no version dimension). | ||
| *** Local set mirrors the version members present in the input file; assignments are hard-coded | ||
| *** to "2024_cond" (latest version in the file, previous default of the removed switch) until module 40 is cleaned up. | ||
| Set NDC_version "NDC data versions present in input file" |
Contributor
There was a problem hiding this comment.
Doesn't this violate the naming convention for sets in modules?
| @@ -1,2 +1,2 @@ | |||
| fm_shareTarget.cs3r | |||
| fm_EmiTargetAbs.cs3r No newline at end of file | |||
| fm_shareTarget.cs4r | |||
Contributor
There was a problem hiding this comment.
same here, these files would have to be renamed if they are only used in this module, no?
…rgets in all techpol realizations as UNFCCC capacity targets are outdated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
This implements the changes from the refactoring of the NDC target preparation in pik-piam/mrremind#853.
Type of change
Indicate the items relevant for your PR by replacing ◻️ with ☑️.
Do not delete any lines. This makes it easier to understand which areas are affected by your changes and which are not.
Parts concerned
Impact
Checklist
Do not delete any line. Leave unfinished elements unchecked so others know how far along you are.
In the end all checkboxes must be ticked before you can merge.
make test) after my final commit and all tests pass (FAIL 0)remind2if and where it was neededforbiddenColumnNamesin readCheckScenarioConfig.R in case the PR leads to deprecated switchesCHANGELOG.mdcorrectly (added, changed, fixed, removed, input data/calibration)Further information (optional)
Runs with these changes are here:
Comparison of results (what changes by this PR?):
/p/tmp/schreyer/Modeling/remind/Dev1/compScen-NDC_Refac-2026-09-29_10.09.50-H12-to2050.pdfVery minor deviations that seem random (US coal power). Same targets and carbon prices.