Fix bare script variable scoping#68
Merged
Merged
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 35b1e90. Configure here.
Treat top-level scripts, module bodies, and definition bodies as separate variable scopes during rename. Resolve plain alias-backed require/import/use references so related rename edits stay consistent.
fc226e9 to
900c89e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

The Problem: Go to definition wasn't working for variables in the top level of an exs script.
Solution: Properly handle this case.
Note
Medium Risk
Changes core rename/go-to-definition scoping and parser index references; incorrect boundaries could mis-rename or miss symbols, mitigated by extensive new tests and an index version bump.
Overview
Fixes variable scoping for bare
.exsscripts (e.g.config/runtime.exs) so top-level bindings are treated as file-scoped, while nesteddef/defmodulebodies stay isolated for rename, occurrence collection, and collision checks.In
internal/treesitter/variables.go, scope discovery now stops at thesourceroot and atdefmodule/defprotocol/defimplcalls; traversals skip nested function and module definitions so same-named locals do not leak across boundaries. Bare top-level identifiers that are only zero-arity calls are not misclassified as variables when a same-named binding exists inside a nesteddef.The tokenized parser resolves
import/use/requiremodule names viaResolveModuleRef(aliases + current module) instead of plainresolveModule, improving indexing in scripts without an enclosing module.Adds LSP rename coverage for plain alias +
requireshort name in the same config file, plus tree-sitter tests for top-level and cross-boundary cases.IndexVersionis bumped to 12 for index rebuilds.Reviewed by Cursor Bugbot for commit 900c89e. Bugbot is set up for automated code reviews on this repo. Configure here.