Fixed a race condition in r_usbh_pipe_xfer_out - #2
Open
vgololobov wants to merge 1 commit into
Open
Conversation
Signed-off-by: Valentyn Gololobov <val@embedd.it>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the FSP,
r_usb_host.c,r_usbh_pipe_xfer_out, the functionr_usbh_pipe_wait_for_readyis called before actually writing to the pipe register. If an output interrupt request is queued it hangs. The call tor_usbh_pipe_wait_for_readyhad to be moved after the write to D0FIFOSEL in order to fix this condition