Conversation
Codecov Report
@@ Coverage Diff @@
## master #6 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 7 7
Lines 561 565 +4
=====================================
+ Hits 561 565 +4
Continue to review full report at Codecov.
|
EmmaLRussell
reviewed
Dec 5, 2019
EmmaLRussell
left a comment
EmmaLRussell
left a comment
Contributor
There was a problem hiding this comment.
Looks good, makes sense. Possible to put in a test for the new behaviour in restart?
Contributor
|
Can we merge this? Useful to have that method exposed! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will resolve secrets earlier in an upgrade, which will prompt for the github token earlier (before images are pulled). By exposing the
resolve_secretsmethod on the constellation object we can also call this when upgrading hintr alone (mrc-1146 - see separate PR in hint-deploy)