[codex] Use channel energy for hit smearing#127
Merged
Conversation
lobis
marked this pull request as ready for review
May 19, 2026 12:01
lobis
enabled auto-merge
May 19, 2026 12:06
Member
Author
|
Follow-up verification on 2026-05-25: this patch is still not present on I also rechecked the failing CI job. The only failing check is |
lobis
disabled auto-merge
May 26, 2026 08:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
TRestDetectorHitsSmearingProcesscan be configured withchannelType=tpcorchannelType=veto, but the resolution was derived fromfInputEvent->GetTotalEnergy(). For mixed events containing both TPC and VETO hits, a large energy deposit in the other channel could bias the selected-channel resolution. This is especially visible in cosmic-background simulations where a small TPC deposit may coexist with a large veto deposit.Validation
git diff --checkon the patch.RestDetectortarget on the NAF REST build tree successfully.