Fix CI: build ssdeep without isolation against setuptools < 81 - #13
Merged
Conversation
ssdeep's setup.py imports pkg_resources, removed in setuptools >= 81. pip's isolated build environment uses a recent setuptools, so getting requirements to build the ssdeep wheel failed with ModuleNotFoundError: No module named 'pkg_resources'. Pre-install setuptools < 81 and wheel, and install requirements with --no-build-isolation so the sdist-only packages (ssdeep, python-tlsh) build against them. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…abling isolation --no-build-isolation broke other sdist builds that rely on isolation to fetch their own build deps (ModuleNotFoundError: No module named 'six'). Keep build isolation and instead pin setuptools < 81 for build envs via PIP_CONSTRAINT, which fixes only the ssdeep pkg_resources build failure. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new CI workflow failed at Install Python dependencies on all three Python versions:
ssdeep'ssetup.pyimportspkg_resources, whichsetuptools >= 81no longer ships. pip's isolated build environment pulls a recentsetuptools, so the build cannot import it.Fix: pre-install
setuptools<81+wheeland install requirements with--no-build-isolation, so the sdist-only packages (ssdeep,python-tlsh) build against the provided tools. Wheel-backed packages (pandas, numpy, scikit-learn, ...) are unaffected. The PR's own CI run validates the fix.🤖 Generated with Claude Code