-
Notifications
You must be signed in to change notification settings - Fork 142
Support for MPT-DEX in Explorer #1302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ckeshava
wants to merge
34
commits into
ripple:main
Choose a base branch
from
ckeshava:mpt-dex
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
34 commits
Select commit
Hold shift + click to select a range
0b8367b
draft: first draft of the MPT-DEX feature support in Explorer
ckeshava cd9ff32
fix existing failing tests
ckeshava 9453ff8
tests: OfferCreate transaction with MPT Amounts
ckeshava 67626a2
test: Payment transaction Simple, Description and Detailed views with…
ckeshava 13c81a6
test: AMMDelete transaction with MPT Amount
ckeshava 54cd50a
test: AMMDeposit tests with MPT amounts
ckeshava 5fc004f
test: AMMCreate transaction with two MPT assets
ckeshava 5782f14
test: AMMClawback tests with MPT assets
ckeshava d31ee18
test: AMMWithdraw transaction with MPT asset/s
ckeshava 8ac00cd
[trivial] linter updates
ckeshava ec33f9c
minor: strongly typed tx parameter in Payment.parser
ckeshava 805e630
minor: do not use shortened MPT-ID values, except in Vault component
ckeshava 7498ce0
fix: Ensure IOU and MPT Currencies are displayed in Green inside Tran…
ckeshava 72a44ea
[trivial] linter complaints
ckeshava 976236f
Merge branch 'main' into mpt-dex
ckeshava a3641a8
minor: refactor commonly used magic numbers/hashes
ckeshava a8f1f71
use Amount type instead of any type
ckeshava ad688b6
test: unit test file for useMPTIssuance hook
ckeshava 416846f
minor: add unit tests for isMPTAsset and isMPTAmount methods
ckeshava ab4553c
Merge branch 'main' into mpt-dex
ckeshava d14cd92
revert unnecessary changes to transactionUtils file
ckeshava d749048
Merge branch 'mpt-dex' of https://github.com/ckeshava/explorer into m…
ckeshava 599e3bc
minor: add unit test for formatAsset MPT case
ckeshava c82d0c3
feat: Use BigInt type to handle potentially large MPTAmount values
ckeshava d20a0c4
feat: remove formatAsset second def in utils.js file
ckeshava 78c4164
minor: wrap tests with QueryClientProvider whenver Currency component…
ckeshava bcf8cff
Merge branch 'main' into mpt-dex
ckeshava ddf45fc
Merge branch 'main' into mpt-dex
ckeshava 4a58b18
fix: resolve CI failures from React 18 / react-router 7 migration
ckeshava 67ba204
feat: Use BigInt for MPTAmount subtraction in Offer meta renderer
ckeshava 08e5675
feat: Preserve MPTAmount precision end-to-end in Amount rendering
ckeshava f18ce99
Merge branch 'main' into mpt-dex
ckeshava 2a15173
feat: Forward isMPT flag to localizeNumber in Offer meta renderer
ckeshava b02b7c6
fix: Strip currency from BigInt branch in localizeNumber for MPT amounts
ckeshava File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
localizeNumber has a argument isMPT, should we set it in all of the localizeNumber calls here (e.g payIsMPT) so that BigInt will be execute?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, fixed in 2a15173
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
follow-up in b02b7c6: added regression tests in Meta.test.tsx covering all 6 localizeNumber calls, plus mixed MPT/XRP offers and the MPToken/MPTokenIssuance renderers. they surfaced a small bug where Intl.NumberFormat rejected the mpt_issuance_id as a currency code (it validates
currencyeven withstyle: decimal) — fix is in the same commit.