Skip to content

feat(frontend): replace dashboard logo mark with new badge design - #5592

Open
NicholasKissel wants to merge 1 commit into
mainfrom
NicholasKissel/replace-dashboard-logo
Open

feat(frontend): replace dashboard logo mark with new badge design#5592
NicholasKissel wants to merge 1 commit into
mainfrom
NicholasKissel/replace-dashboard-logo

Conversation

@NicholasKissel

Copy link
Copy Markdown
Member
  • Replace the dashboard header logo mark (LogoMark) with the new rounded-square badge design (outer frame, gap ring, inner badge, Rivet "R").
  • Keep the mark as an inline SVG using currentColor so it still adapts to light and dark themes; the gap ring and "R" are transparent cutouts.
  • The "rivet" wordmark used on auth/onboarding pages is unchanged.

@railway-app

railway-app Bot commented Aug 24, 2026

Copy link
Copy Markdown

🚅 Deployed to the actors-pr-5592 environment in rivet-frontend

Service Status Web Updated (UTC)
frontend-inspector 😴 Sleeping (View Logs) Web Aug 24, 2026 at 3:14 am
frontend-cloud 😴 Sleeping (View Logs) Web Aug 24, 2026 at 3:12 am
kitchen-sink 😴 Sleeping (View Logs) Web Aug 24, 2026 at 3:11 am
ladle ✅ Success (View Logs) Web Aug 24, 2026 at 3:04 am
mcp-hub ✅ Success (View Logs) Web Aug 24, 2026 at 3:02 am
website ❌ Build Failed (View Logs) Web Aug 24, 2026 at 3:01 am

@claude

claude Bot commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

Review

Small, focused change (single file, +3/-17). A few things worth checking before merge:

Correctness — verify the cutout rendering

The old mark used fillRule="evenodd" / clipRule="evenodd" to make the outline stroke gap and the letterform explicit "holes." The new single <path> drops both and relies on the SVG default nonzero fill-rule plus the winding direction baked into each subpath (outer frame edge vs. inner frame edge, and the "inner badge" vs. its three "R" cutout subpaths). If any of those subpaths were exported/traced with the same winding direction as their enclosing contour, nonzero will fill them solid instead of leaving them as transparent cutouts — silently, with no build error. Since the PR description explicitly calls out "the gap ring and 'R' are transparent cutouts," please confirm this actually renders as intended in a browser (both LogoMark call sites: top-bar.tsx and layout.tsx), and in both light and dark theme per the repo's frontend visual-change guidance.

Code quality — path data looks like a raw trace, not hand-authored

The new d attribute is ~7 KB of single-decimal-precision cubic segments (reads like potrace/Illustrator "trace image" output), versus the previous ~500 bytes of clean rect + evenodd path. Both LogoMark usages render it at h-5 (20px), so this level of anchor-point density is invisible at runtime and just adds bundle size/diff noise. Worth running it through SVGO or simplifying by hand, similar in spirit to the clean geometry the old glyph used.

Consistency — two different marks now coexist

Logo (same file) still renders the old rect + evenodd glyph and is used on auth/onboarding per the PR description, while LogoMark (dashboard header/sidebar, top-bar.tsx + layout.tsx) now renders the new badge. That split is called out as intentional, but it means the app now shows two visually different Rivet marks depending on the page. Worth confirming this is a deliberate staged rollout (with a follow-up to update Logo) rather than an oversight.

Minor

  • viewBox shrank from 68x68 to 64x64 — since both call sites just constrain height (h-5 w-auto), double check the mark's apparent padding relative to surrounding header text/icons hasn't shifted.

Other categories

  • Security: none — static inline SVG, no user input.
  • Test coverage: no tests needed for a presentational logo asset; a Ladle story isn't warranted per the repo's "skip trivial wrappers" guidance.
  • Performance: negligible — one extra <path> string, no runtime cost beyond initial parse.

🤖 Generated with Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant