fix(hub): add missing WebSocket protocol header to inspector - #5596
Open
iinaa-eimrit wants to merge 1 commit into
Open
fix(hub): add missing WebSocket protocol header to inspector#5596iinaa-eimrit wants to merge 1 commit into
iinaa-eimrit wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5481
Description
The Hub UI's Inspector REPL was failing to establish a WebSocket connection because the
Sec-WebSocket-Protocol: rivetheader was not sent. The engine's guard requires this header and rejects the connection without it.Changes Made
Updated
use-websocket.tsxto automatically append therivetprotocol to theReconnectingWebSocketinitialization if it isn't already present.cc @MasterPtato @ajayaccumatic