Repository navigation
Add are_predictions flag to dataset upload - #412
Merged
Merged
Conversation
… sent as a dataset
iurisilvio
reviewed
Sep 9, 2025
| project_type: str = "object-detection", | ||
| batch_name=None, | ||
| num_retries=0, | ||
| are_predictions=False, |
Contributor
There was a problem hiding this comment.
I'd prefer to be consistent and keep using is_prediction.
Contributor
Author
There was a problem hiding this comment.
totally makes sense. I updated.
iurisilvio
previously approved these changes
Sep 9, 2025
iurisilvio
left a comment
iurisilvio
left a comment
Contributor
There was a problem hiding this comment.
LGTM!
You probably want to bump version before merge.
iurisilvio
approved these changes
Sep 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This flag allows dataset uploads to be sent as predictions (not automatically added to the dataset).
Type of change
Please delete options that are not relevant.
How has this change been tested, please provide a testcase or example of how you tested the change?
Unit tests cover this case
Any specific deployment considerations
For example, documentation changes, usability, usage/costs, secrets, etc.
Docs