Skip to content

chore: stricter tsconfig - #1061

Merged
sxzz merged 1 commit into
rolldown:mainfrom
dynst:tsconfig-nounused
Sep 3, 2026
Merged

sxzz merged 1 commit into
rolldown:mainfrom
dynst:tsconfig-nounused

Conversation

@dynst

@dynst dynst commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

AI usage

  • No AI was used in this PR.
  • AI was used:
    • I have carefully reviewed the AI-generated content myself.

Description

Add more strict options to tsconfig.json. These days these options get emitted by default in tsc --init starting with TypeScript 5.9.

Linked Issues

Additional context

@netlify

netlify Bot commented Sep 3, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for tsdown-main ready!

Name Link
🔨 Latest commit b7cb55b
🔍 Latest deploy log https://app.netlify.com/projects/tsdown-main/deploys/6a99c317d2628a0008c60048
😎 Deploy Preview https://deploy-preview-1061--tsdown-main.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@pkg-pr-new

pkg-pr-new Bot commented Sep 3, 2026 •

Copy link
Copy Markdown

Open in StackBlitz

tsdown

pnpm add https://pkg.pr.new/rolldown/tsdown@1061 -D
npm i https://pkg.pr.new/rolldown/tsdown@1061 -D
yarn add https://pkg.pr.new/rolldown/tsdown@1061.tgz -D

create-tsdown

pnpm add https://pkg.pr.new/rolldown/tsdown/create-tsdown@1061 -D
npm i https://pkg.pr.new/rolldown/tsdown/create-tsdown@1061 -D
yarn add https://pkg.pr.new/rolldown/tsdown/create-tsdown@1061.tgz -D

@tsdown/css

pnpm add https://pkg.pr.new/rolldown/tsdown/@tsdown/css@1061 -D
npm i https://pkg.pr.new/rolldown/tsdown/@tsdown/css@1061 -D
yarn add https://pkg.pr.new/rolldown/tsdown/@tsdown/css@1061.tgz -D

@tsdown/exe

pnpm add https://pkg.pr.new/rolldown/tsdown/@tsdown/exe@1061 -D
npm i https://pkg.pr.new/rolldown/tsdown/@tsdown/exe@1061 -D
yarn add https://pkg.pr.new/rolldown/tsdown/@tsdown/exe@1061.tgz -D

tsdown-migrate

pnpm add https://pkg.pr.new/rolldown/tsdown/tsdown-migrate@1061 -D
npm i https://pkg.pr.new/rolldown/tsdown/tsdown-migrate@1061 -D
yarn add https://pkg.pr.new/rolldown/tsdown/tsdown-migrate@1061.tgz -D

commit: b7cb55b

@dynst
dynst force-pushed the tsconfig-nounused branch from a8ffa94 to 6127aaa Compare September 3, 2026 02:06
@dynst
dynst force-pushed the tsconfig-nounused branch from 10df8b9 to b38d903 Compare September 3, 2026 02:13
Comment thread tsconfig.json Outdated
"noUncheckedIndexedAccess": false,
"noUncheckedSideEffectImports": true,
"noUnusedLocals": true,
"noUnusedParameters": true,

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer to disable noUnusedParameters, since ESLint already checked this behavior, and _ as prefix is not necessary.

@dynst
dynst force-pushed the tsconfig-nounused branch from b38d903 to b7cb55b Compare September 3, 2026 18:57
@sxzz
sxzz merged commit f7f0cc3 into rolldown:main Sep 3, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants