Update of the status bar on the hide menu is now called at the completion#244
Open
thibault-carpentier wants to merge 1 commit into
Open
Update of the status bar on the hide menu is now called at the completion#244thibault-carpentier wants to merge 1 commit into
thibault-carpentier wants to merge 1 commit into
Conversation
|
looks so much better! |
|
I merged it in our Fork (Scout24@63685f9) |
|
@loadex how did you make the status bar white ? In my project it's white until I used RESideMenu now my status bar it's black and I can't change the color how to do it please ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix the bad update when switching form two
contentViewControllerwith different status bar colors.When called alongside with a
hideMenuViewControllerthestatusBarNeedsAppearanceUpdatecalled outside the completion block of thehideMenuViewControllerAnimatedcaused the status bar to switch back to the previous contentViewController, since this is triggered before the completionBlock of the animation insetContentViewController.Before fix :


After fix :