Add pages to pdf_overlay_stamp() - #30
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
pagesargument topdf_overlay_stamp().By default if left missing uses all pages.
Implementation in R and C++ closely matches how the
pagesargument forpdf_rotate()is implemented.Note the
qpdfcli overlay operation supports three different types of page ranges:to,from,repeatpagescorresponds to their notion oftoand indicates which pages in the input file should have the stamp overlayed. This use ofpagesseems to match howpagesis used inpdf_rotate().We consolidate the
pagesargument documentationR/qpdf.Rfor all three functions that use it. Note thepagesdocumentation forpdf_subset()was previously quietly getting dropped in favor of thepagesdocumentation forpdf_rotate().I've manually looked at some test pdf output (including those defined in
tests/testthat/test_overlay.R) and it seems to be working as intended.closes #29