Skip to content

Add pages to pdf_overlay_stamp() - #30

Merged
jeroen merged 1 commit into
ropensci:masterfrom
trevorld:overlay-pages
Mar 12, 2026
Merged

Add pages to pdf_overlay_stamp()#30
jeroen merged 1 commit into
ropensci:masterfrom
trevorld:overlay-pages

Conversation

@trevorld

@trevorld trevorld commented Mar 9, 2026

Copy link
Copy Markdown
Contributor
  • Adds a pages argument to pdf_overlay_stamp().

  • By default if left missing uses all pages.

  • Implementation in R and C++ closely matches how the pages argument for pdf_rotate() is implemented.

  • Note the qpdf cli overlay operation supports three different types of page ranges: to, from, repeat

  • We consolidate the pages argument documentation R/qpdf.R for all three functions that use it. Note the pages documentation for pdf_subset() was previously quietly getting dropped in favor of the pages documentation for pdf_rotate().

  • I've manually looked at some test pdf output (including those defined in tests/testthat/test_overlay.R) and it seems to be working as intended.

closes #29

@jeroen
jeroen merged commit 0ac0b34 into ropensci:master Mar 12, 2026
16 of 17 checks passed
@trevorld
trevorld deleted the overlay-pages branch March 12, 2026 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add pages argument to pdf_overlay_stamp()

2 participants