obese-devel github actions to build and run tests#1
Draft
lucasw wants to merge 24 commits intoros-o:obese-develfrom
Draft
obese-devel github actions to build and run tests#1lucasw wants to merge 24 commits intoros-o:obese-develfrom
lucasw wants to merge 24 commits intoros-o:obese-develfrom
Conversation
It's a common approach to build cmake projects in a `build` folder in the project root. It's just that `rosbuild`/`catkin` does not do it, so the changed name never mattered. When you try the target name includes another `build_` string and there is *exactly one* package in the whole ecosystem that relies on this not happening: https://github.com/ros/ros_comm/blob/845f74602c7464e08ef5ac6fd9e26c97d0fe42c9/test/test_rosbag/bag_migration_tests/CMakeLists.txt#L87-L103
with debian sbuild builds this does not exist atm.
…ng in libb64 at fault?
… cause fouling up the function name
lucasw
changed the title
jspricke
force-pushed
the
obese-devel
branch
2 times, most recently
from
9dab066 to
cc931b0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are useful for my ros_comm fork, any interest in having these running here?
I could use some help with the tests that fail and I disabled or others I fixed in less robust ways.
Some patches from https://salsa.debian.org/science-team/ros-ros-comm/-/tree/master/debian/patches?ref_type=heads were applied in order to get the build to work- I could experiment with removing some or all of them (and document what the errors are here), if they are needed maybe they should be committed into obese-devel separate from this PR?
There are dockerfiles that parallel what is in the actions, which is a maintenance hassle- the pattern elsewhere is to run the dockerfiles in the actions and then less duplication, but I prefer the visibility in what is going wrong in an action, and the action steps are a little closer to what someone would run locally. (Another option is add more actions here that also build the dockerfiles to prevent regressions but no guarantees they stay in sync with the other actions).
The big search and replaces of deprecated test function names could be removed here, and maybe brought back in a later PR? I made the replacements to reduce the amount of noise from deprecation warnings while trying to fix the actual failures.