Add GIF input support - #360
Open
ShaiMagal wants to merge 1 commit into
Open
Conversation
Adds image/gif as a supported source type, so GIF images can be converted to WebP the same way PNG and JPEG already are. - InputValidator: allow image/gif through the input mime-type gate - Gd: load via imagecreatefromgif() + availability check - Imagick / Gmagick: accept image/gif (GIF in queryFormats()) - OptionsTrait: support a gif option group (mirrors png / jpeg) Animated GIFs are converted to a single (first) frame static WebP, matching GD's imagecreatefromgif() behaviour.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add GIF input support
This adds
image/gifas a supported source type, so GIF images can be converted to WebP the same way PNG and JPEG already are.Changes
InputValidator– allowimage/gifthrough the input mime-type gateGd– load the source viaimagecreatefromgif(), with the usual "compiled without GIF support" availability checkImagick/Gmagick– acceptimage/gif(checks thatGIFis present inqueryFormats())OptionsTrait– support agifoption group, mirroring the existingpng/jpeggroupsNotes / limitations
imagecreatefromgif()behaviour.$imageTypeternary inOptionsTrait::setProvidedOptions()), in addition to the dedicatedgifgroup added here. Happy to switch GIF to the PNG/lossless path instead if you'd prefer.Real-world use
This patch has been running in production for a while as part of a PrestaShop WebP module, converting user-uploaded GIFs without issues.