fix: compute quartile indices dynamically instead of hardcoding 25/75#96
Merged
iandareid merged 1 commit intoJul 2, 2026
Merged
Conversation
JMoore5353
approved these changes
Jun 25, 2026
Contributor
|
Thanks for the contribution @shanboss! @iandareid I pinged you on this since you are probably code owner of ROSplane... If you think it looks good, go ahead and merge it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes hardcoded Q1/Q3 indices (24/25, 74/75) in barometer calibration
outlier detection. These were hardcoded assuming a vector of exactly
100 elements, which breaks when
baro_calibration_countis changedfrom its default of 100.
Changes
init_static_vector_, instead of hardcoded constants.Testing
hardcoded indices when n=100 (no behavior change at default config)
via a standalone test of the quartile logic
Closes #95