Repository navigation
Meta: Spinel Date runtime, Campfire gate, Writebook emit ledger - #452
Closed
thomasklemm wants to merge 2 commits into
Closed
thomasklemm wants to merge 2 commits into
thomasklemm wants to merge 2 commits into
Conversation
Enable date-only schema columns in the Spinel target with a program-defined Date, ISO SQL date seams, and JSON serialization. Add native emit-and-run coverage and preserve the date boundary on other targets. Refs rubys#303 Co-Authored-By: Codex <noreply@openai.com>
Only emit the program-defined Date class, its RBS, date JSON reopen, and boot requires when the app uses date values. Loading Date#strftime into every Spinel tree currently breaks poly Time|Date receivers (matz/spinel#7334), which 500'd Campfire on /session/new. Also: format_db_date treats "" as nil; escape_value formats Date as YYYY-MM-DD when Date is loaded; analyzer-surface inspect/xmlschema; CI downloads the real-blog fixture for date_columns_spinel; ci-plan owns the serialization file. Refs rubys#303 Co-Authored-By: Cursor Agent <cursoragent@cursor.com> Co-authored-by: Thomas Klemm <github@tklemm.eu>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Comment |
Collaborator
Author
|
Closed in favor of consolidating Spinel dates + Writebook/Campfire Spinel work onto the existing meta PR #451 (user preference: one meta-PR; CI stays separate). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Umbrella Spinel PR. Supersedes and continues #423 (cannot push to
eddygarcas:spinel-date-runtimefrom this agent; please close #423 in favor of this branch, or cherry-pick).Refs #303. Coordinates with #451 (IR/YJIT meta) — this PR does not fight Relation/alloc work unless needed for Spinel compile.
Landed
Date / Spinel (from #423 + follow-ups)
Datefor Spinel (runtime/spinel/date.rb), ISO SQL seams, JSON serialization, emit-and-run suitedate_columns_spinel.app_uses_date(schema date columns or date values in emitted roots). UnconditionalDate#strftimebreaks polyTime|Datedispatch (matz/spinel#7334); Campfire has not.dateand must not load it.format_db_date("")→ nil;SqliteAdapter.escape_value(Date)→YYYY-MM-DD;inspect/xmlschemaon Date.framework-tests-spineldownloadsreal-blog-fixturefordate_columns_spinel; ci-plan owns serialization file.Campfire
runtime/date.rband boot require under this branch (fixes the Add bounded Date runtime for Spinel #423 Campfire 500s from Date load).Writebook
--survey --allow-unsupported.Positionable#move_to_position(each.with_index/ Array append sharing — Spinel subset). Honest ledger of remaining blockers (has_markdown, delegated_type, keyword rest, ingest gaps) continues on this PR.Still open / ledger
Date.currentdefaults,require "date"(Spinel stdlib refusal).Verification
cargo test --locked --test date_columns— 11 passed (includes omit-Date-when-unused).ci:full) including campfire-compare-spinel and date_columns_spinel.Commits (stacked)