Version 0.17 -- update to support winit 0.30 - #66
Closed
mrfoogles wants to merge 4 commits into
Closed
Conversation
…pport winit 0.30, which is a large change.
Contributor
Author
|
Fixes #60. |
…ust calling them manually, as another update pull request does -- it's the same thing
jforberg
reviewed
Jul 15, 2025
| /// You should now run your application logic, calling any of the accessor methods you need. | ||
| /// Call `WinitInputHelper::process_window_event()` for every window event you recieve in ApplicationHandler.window_event() | ||
| /// Call `WinitInputHelper::process_device_event()` every time ApplicationHandler.device_event() is called. | ||
| /// Call `WinitInputHelper::process_new_events()` every time ApplicationHandler.new_events() is called. |
There was a problem hiding this comment.
Function does not exist. WinitInputHelper::step()?
jforberg
reviewed
Jul 15, 2025
| /// Call `WinitInputHelper::process_window_event()` for every window event you recieve in ApplicationHandler.window_event() | ||
| /// Call `WinitInputHelper::process_device_event()` every time ApplicationHandler.device_event() is called. | ||
| /// Call `WinitInputHelper::process_new_events()` every time ApplicationHandler.new_events() is called. | ||
| /// Call `WinitInputHelper::process_about_to_wait()` every time ApplicationHandler.about_to_wait() is called. |
jforberg
reviewed
Jul 15, 2025
|
|
||
| The recommendations this crate gives about where to render and run your application logic have also been updated to match new guidance. | ||
| As update() has been removed, it no longer returns true when you should run application logic. Instead, run your application logic _after_ calling .process_about_to_wait() in ApplicationHandler::about_to_wait(). | ||
| Run rendering code in ApplicationHandler::window_event() only when .process_window_event() returns true, indicating it received a RequestedRedraw event. It doesn't care about which window was requested to be redrawn, but if you do, you'll have to handle it yourself. If you want to render every frame, remember to call Window::request_redraw() in ApplicationHandler::about_to_wait() every time. |
There was a problem hiding this comment.
Functions process_new_events and process_about_to_wait seem to have been renamed to step and end_step
This was referenced Sep 18, 2025
Merged
Owner
|
Many thanks for your work on this, I have completed the move to winit 0.30.0 here: #68 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pretty much everything is done and it seems to work except I don't know how to update the one example for the web, because I can't find the docs. The OS repeating key detection seems to detect the E key as OS repeating whether it is or not (Mac M3), but I assume it did that before as I don't think I changed anything related to that. Also updated the guidance on when to render. This is probably most of the work I'm planning to do, although I wouldn't mind fixing a typo or something (although you can probably do that yourself).