Skip 2 crates#834
Merged
Merged
Conversation
These two crates were discovered in the 1.96.0 beta crater run in rust-lang/rust#155592 (comment) "Steven9101/novasdr-wasm" depends on futuredsp, which already is skipped on crater due to having cfg's for stable/nightly but not for beta. "ecumene/spin_pg" is another instance of the nondeterministic compile failures in rust-lang/rust#137891 (comment). This can be seened in https://github.com/ecumene/spin_pg/blob/594a522b1d7895c1573c33bb2d6f48ea215d76f4/Cargo.lock#L363-L381, where the crate depends on wit-bindgen-rust at two different commits.
jieyouxu
approved these changes
Apr 30, 2026
jieyouxu
left a comment
jieyouxu
left a comment
Member
There was a problem hiding this comment.
Thanks. Looks good, but we need to fix the crate tests prior to be able to merge this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These two crates were discovered in the 1.96.0 beta crater run in rust-lang/rust#155592 (comment)
"Steven9101/novasdr-wasm" depends on futuredsp, which already is skipped on crater due to having cfg's for stable/nightly but not for beta.
"ecumene/spin_pg" is another instance of the nondeterministic compile failures in rust-lang/rust#137891 (comment). This can be seened in https://github.com/ecumene/spin_pg/blob/594a522b1d7895c1573c33bb2d6f48ea215d76f4/Cargo.lock#L363-L381, where the crate depends on wit-bindgen-rust at two different commits.