Add Support for Multiple IRQs in IrqDescriptor - #251
Open
newcomb-luke wants to merge 1 commit into
Open
Conversation
Contributor
|
Belated thanks for this! To my eye this looks like a good update to have - albeit Isaac has changed the crate layout a bit since you opened this PR. @IsaacWoods do you remember why this PR was left on the pile - was it just that you were too busy with v6.0.0? |
Member
Quite possibly! Apologies if so. Now that I'm looking at it, one improvement could be for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simply makes IRQs an enum which can contain a single interrupt or multiple. This helps with keeping most of previous compatibility with minimal changes. This would still be a breaking API change though.
Related to and closes #250