Add Android Compare chart value scrubbing#529
Open
kavemang wants to merge 1 commit into
Open
Conversation
kavemang
marked this pull request as ready for review
July 16, 2026 21:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The Android Compare chart only drew static normalized lines. Users could see the overall shapes and min/max legend, but could not inspect the actual values for a specific day. The Apple Compare chart already provides this crosshair and multi-series value readout.
Tapping now keeps a day selected for inspection. Horizontal dragging scrubs across days and clears the transient selection when released. If a selected metric has no value on that day, the tooltip shows an em dash rather than inventing or carrying a value.
Validation
./gradlew :app:testFullDebugUnitTest --tests com.noop.ui.CompareChartSelectionTest./gradlew :app:testFullDebugUnitTestpython Tools/i18n_audit.py --ci upstream/maingit diff --checkAddresses the remaining Android chart-value visualization gap in #300.