Fix physics property crash with some modded blocks#685
Merged
Ocelot5836 merged 1 commit intomainfrom May 4, 2026
Merged
Conversation
Ocelot5836
added
minor change
ryanhcode
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Twilight forest uses neighboring blocks to determine what its voxel shape should be. However, this is not allowed when calculating physics properties as it causes a recursive update in some cases. This prevents mods from loading chunks when calculating physics properties by treating the block as a single block in a void world. This will likely produce incorrect results for twilight forest, but they should be trying to set the voxel shape based on neighbors.
Closes #387 and related duplicates