Skip to content

Fix Expected VAR_SIGN error when resolving PR review threads - #20

Merged
mrbiggred merged 1 commit into
mainfrom
feature/fix-xxpected-var-sign-error
Jul 10, 2026
Merged

Fix Expected VAR_SIGN error when resolving PR review threads#20
mrbiggred merged 1 commit into
mainfrom
feature/fix-xxpected-var-sign-error

Conversation

@mrbiggred

Copy link
Copy Markdown
Member

Sometimes an Expected VAR_SIGN, actual: UNKNOWN_CHAR error is raised when resolving a review conversation with the smp-apply-github-pr-feedback skill. The error happens when the GraphQL query declares variables (e.g. mutation($threadId: ID!) with -f threadId=...) and the $ characters get mangled by shell quoting.

This change strengthens the existing inline-values guidance in two ways:

  • references/graphql-queries.md now names the Expected VAR_SIGN error and explains why variable declarations trigger it, so the guidance is grounded rather than an unexplained rule.
  • The skill's Error Handling section now includes a recovery path: if a GraphQL call fails with this error, rewrite the query with inline values instead of retrying the same command (the failure transcript in the issue shows the same broken command being retried verbatim).

Closes #10

@mrbiggred mrbiggred closed this Jul 10, 2026
@mrbiggred
mrbiggred deleted the feature/fix-xxpected-var-sign-error branch July 10, 2026 17:13
@mrbiggred
mrbiggred restored the feature/fix-xxpected-var-sign-error branch July 10, 2026 20:59
@mrbiggred mrbiggred reopened this Jul 10, 2026
@mrbiggred
mrbiggred requested a review from Copilot July 10, 2026 21:08
@mrbiggred mrbiggred self-assigned this Jul 10, 2026
@mrbiggred mrbiggred added the bug Something isn't working label Jul 10, 2026
@mrbiggred mrbiggred added this to the v1.1.0 milestone Jul 10, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the smp-apply-github-pr-feedback skill documentation to better diagnose and recover from a GitHub GraphQL parsing failure (Expected VAR_SIGN, actual: UNKNOWN_CHAR) that can occur when shell quoting mangles $ in GraphQL variable declarations.

Changes:

  • Adds explicit error recognition + recovery guidance to the skill’s Error Handling section (rewrite to inline GraphQL values instead of retrying a variables-based query).
  • Expands references/graphql-queries.md to name the error, explain the root cause (shell quoting affecting $), and reinforce the “inline values only” rule with concrete examples.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
plugins/smp-github/skills/smp-apply-github-pr-feedback/SKILL.md Adds a concrete recovery path when GraphQL calls fail with the VAR_SIGN parsing error.
plugins/smp-github/skills/smp-apply-github-pr-feedback/references/graphql-queries.md Strengthens inline-values guidance by naming the error and explaining why variable declarations can trigger it.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mrbiggred
mrbiggred merged commit 4ea59a7 into main Jul 10, 2026
3 checks passed
@mrbiggred
mrbiggred deleted the feature/fix-xxpected-var-sign-error branch July 10, 2026 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Expected VAR_SIGN error with smp-apply-github-pr-feedback

2 participants