Fix Expected VAR_SIGN error when resolving PR review threads - #20
Merged
Conversation
…ry guidance when resolving review threads
There was a problem hiding this comment.
Pull request overview
Updates the smp-apply-github-pr-feedback skill documentation to better diagnose and recover from a GitHub GraphQL parsing failure (Expected VAR_SIGN, actual: UNKNOWN_CHAR) that can occur when shell quoting mangles $ in GraphQL variable declarations.
Changes:
- Adds explicit error recognition + recovery guidance to the skill’s Error Handling section (rewrite to inline GraphQL values instead of retrying a variables-based query).
- Expands
references/graphql-queries.mdto name the error, explain the root cause (shell quoting affecting$), and reinforce the “inline values only” rule with concrete examples.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| plugins/smp-github/skills/smp-apply-github-pr-feedback/SKILL.md | Adds a concrete recovery path when GraphQL calls fail with the VAR_SIGN parsing error. |
| plugins/smp-github/skills/smp-apply-github-pr-feedback/references/graphql-queries.md | Strengthens inline-values guidance by naming the error and explaining why variable declarations can trigger it. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes an
Expected VAR_SIGN, actual: UNKNOWN_CHARerror is raised when resolving a review conversation with thesmp-apply-github-pr-feedbackskill. The error happens when the GraphQL query declares variables (e.g.mutation($threadId: ID!)with-f threadId=...) and the$characters get mangled by shell quoting.This change strengthens the existing inline-values guidance in two ways:
references/graphql-queries.mdnow names theExpected VAR_SIGNerror and explains why variable declarations trigger it, so the guidance is grounded rather than an unexplained rule.Closes #10