feat: add key syncing and rotation - #1
Open
oshinop wants to merge 1 commit into
Open
Conversation
Collaborator
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5e761b269b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
AsakuraMizu
requested changes
Jul 20, 2026
AsakuraMizu
left a comment
Collaborator
There was a problem hiding this comment.
感谢补充轮换和失败回滚能力。这个 PR 的主要问题是改变了现有契约:用户从“必须有且仅有一个 API Key”变成了允许无 Key,并为此引入了 nullable 字段、创建/删除、版本号、CAS 和同步逻辑。更严重的是,current_user() 每次都会读取上游全量 Key 并可能回写 SQLite,使普通认证请求依赖 CliRelay,同时让 Gate 和 CliRelay 各自保存一份需要同步的 Key,增加了不一致风险。建议保留失败回滚和显式轮换,但继续维持一用户一 Key,不支持创建/删除,也不要在读取用户时同步上游;这个 PR 需要按这个方向重新设计后再提交。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.