Skip to content

feat: add key syncing and rotation - #1

Open
oshinop wants to merge 1 commit into
mainfrom
feat/api-key-syncing-and-rotation
Open

feat: add key syncing and rotation#1
oshinop wants to merge 1 commit into
mainfrom
feat/api-key-syncing-and-rotation

Conversation

@oshinop

@oshinop oshinop commented Jul 19, 2026

Copy link
Copy Markdown

No description provided.

@oshinop
oshinop requested a review from AsakuraMizu July 19, 2026 12:53
@AsakuraMizu

Copy link
Copy Markdown
Collaborator

@codex

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5e761b269b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/clients/clirelay.rs

@AsakuraMizu AsakuraMizu left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

感谢补充轮换和失败回滚能力。这个 PR 的主要问题是改变了现有契约:用户从“必须有且仅有一个 API Key”变成了允许无 Key,并为此引入了 nullable 字段、创建/删除、版本号、CAS 和同步逻辑。更严重的是,current_user() 每次都会读取上游全量 Key 并可能回写 SQLite,使普通认证请求依赖 CliRelay,同时让 Gate 和 CliRelay 各自保存一份需要同步的 Key,增加了不一致风险。建议保留失败回滚和显式轮换,但继续维持一用户一 Key,不支持创建/删除,也不要在读取用户时同步上游;这个 PR 需要按这个方向重新设计后再提交。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants