Unblock native group-level analysis and source localization workflows#254
Open
google-labs-jules[bot] wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Researchers using EEGPrep were previously unable to complete end-to-end group-level analyses or basic source localization within the application. Critical UI entry points for
STUDYandDIPFITwere blocked by placeholders, forcing users to switch back to MATLAB to perform standard tasks like condition comparison or dipole fitting.This PR replaces those placeholders with functional implementations, wiring existing internal libraries to the user interface to satisfy basic research needs.
Key Changes
1. STUDY Design & Statistics
pop_limoDialog: Replaced the limitation exception insrc/eegprep/functions/studyfunc/pop_limo.pywith a functionalDialogSpecUI. This allows users to select categorical and continuous independent variables directly within the native interface.statcond.py) to handleSTUDYdictionary structures. It now usesstd_readdatato retrieve condition arrays, enabling permutation tests for group comparisons without external dependencies.2. Source Localization (DIPFIT)
headplot_manual_coregcallback, users can now align channel locations to the supported native spherical head model.std_dipplot.pyusingmatplotlib. This replaces the previous plotting placeholders and allows for the visual inspection of dipole clusters.Rationale & Key Decisions
DialogSpecsystem to ensure visual and behavioral parity with the rest of the EEGPrep suite.Validation Results
pop_limoandpop_dipfit_settingsdialogs launch and save state correctly.test_study_end_to_end.pynow pass without hitting "Not Implemented" errors.