Skip to content

feat: allow setting listen address explicitly#285

Closed
Pandapip1 wants to merge 1 commit into
sccn:devfrom
Pandapip1:explicit-addresses
Closed

feat: allow setting listen address explicitly#285
Pandapip1 wants to merge 1 commit into
sccn:devfrom
Pandapip1:explicit-addresses

Conversation

@Pandapip1

Copy link
Copy Markdown

This allows for the address to be set explicitly, for applications which would prefer to set their own addresses without using the config file.

WIP; currently in the process of being tested

@cboulay

cboulay commented Jun 27, 2026

Copy link
Copy Markdown
Collaborator

Hi @Pandapip1 ,

Believe me, I would love this feature. It would fix a bunch of headaches for me. However, I am extremely reluctant to change the API surface like this, especially when it's something that can be handled with the config file (and possibly requiring #278 and #279). Would runtime config changing then be enough?

liblsl's API changes slowly and that's on purpose. There are manufacturers and government agencies who use liblsl in various capacities at least in-part because it is stable.

I realize that this proposed change does not break the existing API. I'm more concerned about putting out a release with this change then discovering some fundamental problem (e.g., related to security which is an increasing concern) and then we have to break the API to remove this.

I'm happy to leave this PR open for a while (indefinitely) for public comment.

Cheers,
Chad

@Pandapip1

Copy link
Copy Markdown
Author

Thanks for the early comment; if this is something that's unlikely to be accepted then I'll be prioritizing working on and testing some other things. I'll close this PR but I'll keep the branch; if anyone wants to fork from it they should free to do so.

@Pandapip1 Pandapip1 closed this Jun 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants