Skip to content

chore: delete two pieces of dead configuration - #59

Merged
lsimons merged 2 commits into
mainfrom
chore/drop-dead-config
Jul 31, 2026
Merged

chore: delete two pieces of dead configuration#59
lsimons merged 2 commits into
mainfrom
chore/drop-dead-config

Conversation

@lsimons

@lsimons lsimons commented Jul 31, 2026

Copy link
Copy Markdown
Member

Two unrelated dead-config removals, one commit each so either can be dropped.

1. gitlab_group on MappingEntry (#42)

src/mdd/sharepoint/mapping.py carried a GitLab-specific default —
gitlab_group: str = field(default="mdd/sharepoint") — into the provider-neutral
core. Two independent problems: it is a house default for a specific group path
on a specific GitLab instance, sitting in the layer whose mirror seam exists so
that a backend supplies exactly that; and the field was dead — parsed,
validated, defaulted, stored, and never read.

The issue could not determine whether a downstream wrapper read it off
MappingEntry. That has now been checked: neither the private SBP wrapper nor
the public lsimons/mdd-wrapper reference wrapper contains any reference to
gitlab_group.
So it is simply dead, and this deletes it — field, constant,
parse branch, the config-example lines in mapping.py and
configs/sharepoint-mapping.yaml, the documented key in S10, and the one test
that only asserted the parse round-trip.

Fixes #42

2. The test-corpus mise task (#48)

mise run test-corpus has never worked in this repository. It pointed at
tests/confluence/test_corpus_smoke.py, which is absent from the working tree
and from all of git history — the task was already dangling in the initial
commit. pytest exits 4 (usage error), so it was a hard task failure, not an
empty-but-passing run. It went unnoticed because test-corpus is not in the
ci task's depends list.

There is no Confluence corpus smoke test anywhere, and the corpus is already
exercised by mise run ir-coverage, mise run ir-roundtrip and
tests/sharepoint/test_corpus_matrix.py, each with its own task. So the task is
deleted rather than repointed at a test that already has one — which also
removes a misleading entry from mise tasks.

Fixes #48

Not done here

The issue raises whether a check that every [tasks.*].run path exists would be
worthwhile, since a dangling task path is silent today. Deliberately out of
scope; worth a follow-up issue.

Co-Authored-By: lsimons-bot bot@leosimons.com

lsimons and others added 2 commits July 31, 2026 09:25
gitlab_group carried a GitLab-specific default ("mdd/sharepoint") into
the provider-neutral core, and was parsed, validated, and stored but
never read by any consumer in this repo or the private/reference
wrapper distributions. Delete the field, its default constant, the
parse branch, the three tests asserting only the parse round-trip, and
every doc/config mention of the key.

Fixes #42

Co-Authored-By: lsimons-bot <bot@leosimons.com>
Assisted-by: Claude:claude-sonnet-5
test-corpus pointed at tests/confluence/test_corpus_smoke.py, which
does not exist in the working tree or anywhere in git history — it was
already dangling in the initial commit. It fails immediately with a
pytest usage error and is not in the ci task's depends list, so the
break went unnoticed. Confluence corpus coverage is already carried by
ir-coverage, ir-roundtrip, and the sharepoint corpus matrix test, each
with its own task, so there is nothing to repoint this at.

Fixes #48

Co-Authored-By: lsimons-bot <bot@leosimons.com>
Assisted-by: Claude:claude-sonnet-5
@lsimons
lsimons merged commit 5d58d49 into main Jul 31, 2026
7 checks passed
@lsimons
lsimons deleted the chore/drop-dead-config branch July 31, 2026 11:09
@lsimons lsimons added this to MDD Jul 31, 2026
@github-project-automation github-project-automation Bot moved this to Done in MDD Jul 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

1 participant