fix(plot): take sqrt for gaussian fit sigma initial guess#698
Open
henryiii wants to merge 1 commit into
Open
Conversation
_construct_gaussian_callable assigned the variance to sigma, which the gauss closure then squared again. Take the square root so the initial guess is a true standard deviation. Closes #483. Assisted-by: ClaudeCode:claude-opus-4.8
henryiii
force-pushed
the
fix-plot-gaussian-sigma
branch
from
598bded to
8af8b4e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 AI text below 🤖
Closes #483.
_construct_gaussian_callableassigned the variance tosigma, and thegaussclosure then used2 * np.square(sigma)— effectively squaring the variance. The initial-guess sigma is nownp.sqrt(variance), a true standard deviation.Test:
tests/test_plot.py::test_construct_gaussian_callable_sigmabuilds a histogram from a known Gaussian (std 2.0), calls_construct_gaussian_callabledirectly (no--mplneeded), and asserts the recovered sigma ≈ 2.0 (was ≈ 4.0). Confirmed failing before, passing after.