Automatically re-auth in case the token is invalid after reconnecting - #66
Merged
Merged
Conversation
Member
|
Hey @SystemParadox , I think this improvement is still relevant. I'm happy to review the change once the merge conflicts are resolved. |
Member
|
Feel free to ping me here or on Discord for a review whenever you get a chance to rebase your changes. |
SystemParadox
force-pushed
the
fix-reconnections
branch
from
August 18, 2026 15:47
db7787c to
d786734
Compare
SystemParadox
force-pushed
the
fix-reconnections
branch
from
August 18, 2026 15:52
d786734 to
b51b686
Compare
Contributor
Author
|
@DocDvorak updated. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After reconnecting the websocket connection it has to re-auth, but the token may be invalid by this point. Updated
connect()to automatically get a new token and re-auth if the auth fails the first time after connecting.I was going to add a check so that it only does this when reconnecting and doesn't retry at all when just connecting initially, but then I realised that this does actually apply to the first connect as well - it is possible that there was a long delay between getting the token and deciding to start a websocket connection, so the token may also be invalid in that case.