You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
fall back to the session API after DDL schema-refresh agreement fails
I don't think this is correct. The purpose of after-DDL schema agreement is to make sure that all the nodes acknowledged the new schema notification.
If you perform the schema agreement check on a different node, it is possible that it is the node that didn't get the schema change yet, and will get a false-positive schema agreement.
After-DDL schema agreement should be performed on the node we used for DDL. We can use different connection, but not different node.
fall back to the session API after DDL schema-refresh agreement fails
I don't think this is correct. The purpose of after-DDL schema agreement is to make sure that all the nodes acknowledged the new schema notification. If you perform the schema agreement check on a different node, it is possible that it is the node that didn't get the schema change yet, and will get a false-positive schema agreement.
After-DDL schema agreement should be performed on the node we used for DDL. We can use different connection, but not different node.
It does it on all active nodes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Fixes #604
Testing: