Replace _graphdef with _ for unused variables in NNX tutorials#307
Merged
da-niao-dan merged 2 commits intoDec 19, 2025
Merged
Conversation
Co-authored-by: da-niao-dan <9532472+da-niao-dan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add more NNX and SL tutorials
Replace _graphdef with _ for unused variables in NNX tutorials
Dec 19, 2025
85cdb7a
into
peicheng/nnx_split_learning_tutorial
4 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace prefixed unused variable
_graphdefwith the standard Python convention_for intentionally unused return values in tutorial examples.Changes
_graphdef, state = nnx.split(model)with_, state = nnx.split(model)(2 instances)_graphdef, state = nnx.split(model)with_, state = nnx.split(model)(3 instances in model initialization functions)The graphdef is not needed in these contexts as models are reconstructed from their class definitions when deserializing state dicts.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.