feat(spu_state): expose brpc protocol/connection_type via BrpcLinkConfig#411
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a configurable BrpcLinkConfig dataclass to customize the brpc-backed SPU link settings (such as protocol, connection type, timeout, and payload size) via environment variables or explicit constructor arguments. Feedback on these changes highlights a potential cache collision issue where the cached template links do not account for the new brpc_config. To address this, reviewers suggest making BrpcLinkConfig frozen (immutable and hashable) so it can be safely included in the cache key, and improving the environment variable parsing to handle empty strings more robustly.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
2 participants
No description provided.