Skip to content

Add --verbose runner output option with OS included - #12

Merged
alexellis merged 1 commit into
masterfrom
add-runner-os
Aug 21, 2026
Merged

alexellis merged 1 commit into
masterfrom
add-runner-os

Conversation

@alexellis

Copy link
Copy Markdown
Member

Summary

  • add -v/--verbose to actuated-cli runners
  • request the controller's expanded runner table containing OS
  • preserve the existing default table and JSON output
  • document and test the verbose API query

Depends on the controller change in openfaasltd/actuated#186.

Testing

  • go test ./...
  • go build ./...
  • gofmt -l returned no changed Go files
  • git diff --check

Add a verbose flag to the runners command and request the expanded
controller table so users can see each agent's operating system.
Document the flag and cover its API query contract.

Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
@reviewfn

reviewfn Bot commented Aug 21, 2026

Copy link
Copy Markdown

AI Pull Request Overview

Disclaimer: This review was generated by automated AI and may contain errors. Do not trust its outputs without human verification.

Summary

  • Adds --verbose/-v support to actuated-cli runners.
  • Sends verbose=1 to the runners API when verbose output is requested.
  • Keeps the existing JSON request path and updates the upgrade --all caller for the new client signature.
  • Adds a focused client test for the verbose runners query.
  • Documents the verbose runners usage in the README.

Approval rating (1-10)

9/10. The change is small, scoped, and consistent with existing command/client patterns, with no blocking findings from static review.

Summary per file

Summary per file
File path Summary
README.md Documents verbose runner table usage.
cmd/runners.go Adds verbose flag and forwards it to the client.
cmd/upgrade.go Updates ListRunners call for new signature.
pkg/client.go Adds verbose=1 query parameter support.
pkg/client_runners_test.go Verifies verbose runners API request construction.

Overall Assessment

The implementation is narrowly scoped and follows the repository's existing command and client conventions. The new flag is wired through to the runners API without changing the default table or JSON request behavior, and the added test covers the key request-level behavior. I did not find any blocking correctness, compatibility, or documentation issues in the scoped diff.

Detailed Review

Detailed Review

No blocking findings.

AI agent details.

Agent processing time: 1m0.044s
Environment preparation time: 3.419s
Total time from webhook: 1m6.369s

@alexellis
alexellis merged commit 97c8dfa into master Aug 21, 2026
3 checks passed
@alexellis
alexellis deleted the add-runner-os branch August 21, 2026 09:02
@alexellis alexellis changed the title Add verbose runner output Add --verbose runner output option with OS included Aug 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant