Repository navigation
Add --verbose runner output option with OS included - #12
Merged
Merged
Conversation
Add a verbose flag to the runners command and request the expanded controller table so users can see each agent's operating system. Document the flag and cover its API query contract. Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
AI Pull Request OverviewDisclaimer: This review was generated by automated AI and may contain errors. Do not trust its outputs without human verification. Summary
Approval rating (1-10)9/10. The change is small, scoped, and consistent with existing command/client patterns, with no blocking findings from static review. Summary per fileSummary per file
Overall AssessmentThe implementation is narrowly scoped and follows the repository's existing command and client conventions. The new flag is wired through to the runners API without changing the default table or JSON request behavior, and the added test covers the key request-level behavior. I did not find any blocking correctness, compatibility, or documentation issues in the scoped diff. Detailed ReviewDetailed ReviewNo blocking findings. AI agent details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
-v/--verbosetoactuated-cli runnersDepends on the controller change in openfaasltd/actuated#186.
Testing
go test ./...go build ./...gofmt -lreturned no changed Go filesgit diff --check