fix(components): update sidebar trigger size when collapsed to icon-only#11174
Open
saadpocalypse wants to merge 2 commits into
Open
fix(components): update sidebar trigger size when collapsed to icon-only#11174saadpocalypse wants to merge 2 commits into
saadpocalypse wants to merge 2 commits into
Conversation
Contributor
|
@saadpocalypse is attempting to deploy a commit to the shadcn-pro Team on Vercel. A member of the Team first needs to authorize it. |
saadpocalypse
force-pushed
the
fix/sidebar-trigger-collapsed-size
branch
from
July 14, 2026 21:47
e01df04 to
0b9825c
Compare
saadpocalypse
force-pushed
the
fix/sidebar-trigger-collapsed-size
branch
from
July 16, 2026 20:08
9f12b97 to
e66f72d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes an alignment and sizing mismatch where the
SidebarTriggerbutton inside a collapsed (collapsible="icon") sidebar rail rendered atsize-7(28px) instead of matching thesize-8(32px) dimensions applied to other menu buttons (SidebarMenuButton).Relates to
Fixes #11167
Changes
group-data-[collapsible=icon]:size-8!toSidebarTriggerwithinapps/v4/registry/bases/base/ui/sidebar.tsx,bases/radix/ui/sidebar.tsx, and legacynew-york-v4/ui/sidebar.tsx.pnpm registry:build) to correctly build combinations with the updated styling classes.